Fix: Message tooltip was rendered in an old position [web] #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ashoat
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
This change makes sense to me, but I would love if @palys-swm could take a look too.
Thanks for taking the time to fix this bug @def-au1t – it's really appreciated!! This is probably our first real PR :)
palys-swm
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR contains a small fix for an issue with web tooltip, that was rendered in incorrect position, when the screen was scrolled before opening it. In particular, after entering mouse over the message for the first time, the tooltip was not opening at all.
The source of the issue was introduced probably in this commit (cc: @palys-swm). Originally (almost a year ago when I created that logic) in
onMouseEnterhandler,findTooltipPositionwas called with message position calculated directly fromgetBoundingClientRect, but after the problem was introduced, it was called with position kept in the state, that was not updated until the next render.Resources:
Videos demonstrating the tooltip behavior before and after the fix:
Before:
comm_before_fix.mp4
After:
comm_after_fix.mp4